[Block Library - Query]: Allow term addition from user case-insensitive input #31301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
Size Change: +58 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
|
Not a code review, but the PR solves the issue. |
mcsf
approved these changes
May 14, 2021
packages/block-library/src/query/edit/query-inspector-controls.js
Outdated
Show resolved
Hide resolved
mcsf
reviewed
May 14, 2021
Comment on lines
+139
to
+148
| const termIds = Array.from( | ||
| newTermValues.reduce( ( accumulator, termValue ) => { | ||
| const termId = getTermIdByTermValue( | ||
| terms.mapByName, | ||
| termValue | ||
| ); | ||
| if ( termId ) accumulator.add( termId ); | ||
| return accumulator; | ||
| }, new Set() ) | ||
| ); |
There was a problem hiding this comment.
Out of curiosity, I compared the performance of this "reduce to a set then cast back to array" approach with Lodash's uniq, and uniq performs better, even though the performance is more variable:
This is just an interesting tidbit, not something that needs to be fixed!
There was a problem hiding this comment.
Interesting indeed... I'll have to look into this a bit in general, as I'm quite fond of reduce 😄
ntsekouras
force-pushed
the
add/query-user-entered-term-case-insensitive-addtion
branch
from
f8b3c66 to
3d4f31c
Compare
ntsekouras
force-pushed
the
add/query-user-entered-term-case-insensitive-addtion
branch
from
3d4f31c to
af7ba55
Compare
ntsekouras
deleted the
add/query-user-entered-term-case-insensitive-addtion
branch
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #31258
Currently
FormTokenFieldwhich is used inQueryblock for adding categories and tags, shows suggestions that are case insensitive. The actual addition though was performed by trying to find a case sensitive match and that resulted in not adding a term if the user pressedEnteror tried to separate withcomma.This PR adds an extra check for entered terms in a non case sensitive way, to better match user expectations. I tried to find a better place for this behavior in
FormTokenFieldbut it seemed as a more specific case and added in Query for now.Testing instructions
Queryblock withinheritset tofalseandpost typetopost, to be able to change the categories/tagscategoriesfield the category you created but in a case insensitive way (example if the category isappletypeAPple) and then pressEnteror separate withcomma.